Lock Phive version for PHP 7.3/7.4#957
Merged
Merged
Conversation
Latest Phive (0.16.0) claims to require PHP 8.0 or later[1]. While I have not found any issues running it under PHP 7.4, it might be better to stick with Phive 0.15.3 for PHP 7.3/7.4. [1] <https://github.com/phar-io/phive/releases/tag/0.16.0>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #957 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 7 7
Lines 815 818 +3
Branches 294 295 +1
=========================================
+ Hits 815 818 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
name: ⚙ Improvement
about: Update Phive configuration
labels: enhancement
Description
Latest Phive (0.16.0) claims to require PHP 8.0 or later[1]. While I have not found any issues running it under PHP 7.4, it might be better to stick with Phive 0.15.3 for PHP 7.3/7.4.
[1] https://github.com/phar-io/phive/releases/tag/0.16.0
npm run formatbefore the commit.npm run lintbefore the commit.npm run releasebefore the commit.npm testreturns with no unit test errors and all code covered.I'm not sure whether this change needs a dedicated discussion, but if you deem it sensible, I'll open one.